Uwe Schuster
b3b2903c75
Replace substring `html.replace(old_src, new_src)` with a regex anchored to <script src="…"> / <link href="…"> attribute values. Inert occurrences in comments, JSON literals, or unrelated attributes are left alone. Loud warning (stderr) when zero matches occur — previously the script silently skipped a typo'd old_src. Also rewrites <link href> in the same pass so adjacent CSS hashing doesn't need a follow-up edit. Tests: tests/test_inject_hashed_filenames.py covers happy path (both quote styles, extra attributes), inert-substring cases (comment, JSON literal, data-attr, anchor href), and link-href rewriting. Closes #3 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
77 lines
2.8 KiB
Python
77 lines
2.8 KiB
Python
"""Tests for bin/inject-hashed-filenames.py rewrite() (#3).
|
|
|
|
Pinned behaviour: the rewrite is tag-aware — only `<script src="…">` and
|
|
`<link href="…">` attribute values are replaced. Inert occurrences of the
|
|
old src in HTML comments, JSON literals, or unrelated attributes must be
|
|
left alone (the previous `html.replace` was substring-blind).
|
|
"""
|
|
import importlib.util
|
|
import os
|
|
import sys
|
|
|
|
HERE = os.path.dirname(os.path.abspath(__file__))
|
|
SCRIPT = os.path.join(os.path.dirname(HERE), "bin", "inject-hashed-filenames.py")
|
|
|
|
spec = importlib.util.spec_from_file_location("ihf", SCRIPT)
|
|
ihf = importlib.util.module_from_spec(spec)
|
|
sys.modules["ihf"] = ihf
|
|
spec.loader.exec_module(ihf)
|
|
|
|
|
|
def test_rewrites_script_src_double_quoted():
|
|
html = '<script src="/static/dist/app.js"></script>'
|
|
out, n = ihf.rewrite(html, "/static/dist/app.js", "/static/dist/app.abc123.js")
|
|
assert n == 1
|
|
assert out == '<script src="/static/dist/app.abc123.js"></script>'
|
|
|
|
|
|
def test_rewrites_script_src_single_quoted():
|
|
html = "<script src='/static/dist/app.js'></script>"
|
|
out, n = ihf.rewrite(html, "/static/dist/app.js", "/static/dist/app.abc123.js")
|
|
assert n == 1
|
|
assert "/static/dist/app.abc123.js" in out
|
|
|
|
|
|
def test_rewrites_link_href():
|
|
html = '<link rel="stylesheet" href="/static/dist/app.css">'
|
|
out, n = ihf.rewrite(html, "/static/dist/app.css", "/static/dist/app.abc123.css")
|
|
assert n == 1
|
|
assert '/static/dist/app.abc123.css' in out
|
|
|
|
|
|
def test_does_not_rewrite_inside_html_comment():
|
|
html = '<!-- old script was at /static/dist/app.js --><script src="/other.js"></script>'
|
|
out, n = ihf.rewrite(html, "/static/dist/app.js", "/static/dist/app.abc123.js")
|
|
assert n == 0
|
|
assert "/static/dist/app.js" in out
|
|
assert "/static/dist/app.abc123.js" not in out
|
|
|
|
|
|
def test_does_not_rewrite_inside_json_literal():
|
|
html = '<pre>{ "src": "/static/dist/app.js" }</pre>'
|
|
out, n = ihf.rewrite(html, "/static/dist/app.js", "/static/dist/app.abc123.js")
|
|
assert n == 0
|
|
assert out == html
|
|
|
|
|
|
def test_does_not_rewrite_unrelated_attribute():
|
|
html = '<img data-bundle="/static/dist/app.js">'
|
|
out, n = ihf.rewrite(html, "/static/dist/app.js", "/static/dist/app.abc123.js")
|
|
assert n == 0
|
|
assert out == html
|
|
|
|
|
|
def test_does_not_rewrite_anchor_href():
|
|
# Even though <a href="…"> is a `href` attribute, it isn't a <link>.
|
|
html = '<a href="/static/dist/app.js">debug link</a>'
|
|
out, n = ihf.rewrite(html, "/static/dist/app.js", "/static/dist/app.abc123.js")
|
|
assert n == 0
|
|
assert out == html
|
|
|
|
|
|
def test_rewrites_with_extra_attributes_around_src():
|
|
html = '<script type="module" src="/static/dist/app.js" defer></script>'
|
|
out, n = ihf.rewrite(html, "/static/dist/app.js", "/static/dist/app.abc123.js")
|
|
assert n == 1
|
|
assert '/static/dist/app.abc123.js' in out
|
|
assert 'type="module"' in out and 'defer' in out
|