Uwe Schuster
9976efe1de
L-1 RequireRole: guard std::stoi on the bundle id — a non-numeric/out-of-range
value now yields a clean 401 instead of an uncaught exception → 500.
AuthPrincipal::id documented as numeric-only (carry UUIDs in username).
L-2 SmtpTransport: require TLS (CURLUSESSL_ALL) for non-loopback relays so a
stripped STARTTLS can't downgrade credentials/body to cleartext; localhost
relay stays opportunistic.
L-3 AuditLog: escapeJson now escapes all control chars (RFC 8259) so a newline
in a field can't forge/corrupt the audit JSON; SKIP_FIELDS gains credential
names (password/passwordHash/tlsCertDn/apiKey/token/secret) so secrets never
land in changed_fields.
L-4 ws/Hub: consume the thread_local auth handoff once, up front, and clear it
unconditionally — a stale value can't attach to a later connection on a
reused worker thread.
L-5 TemporalRepository: default id generator draws 128 bits from the platform
CSPRNG (std::random_device) per call instead of a once-seeded mt19937_64,
so entity_ids aren't predictable from observed output.
L-6 AuthInterceptor: expired-session sweep is now a lock-free atomic timer and
exception-isolated; documented that resolveBySessionHash() must enforce
expiry at query time (the sweep is GC only).
L-7 new util/ConstantTime.hpp (constantTimeEquals) + TokenHasher doc requiring a
>=256-bit cryptographic hash.
L-8 IQueryable: likeEscape + Field::likeContains/likePrefix emit
`LIKE ? ESCAPE '\'` with %/_/\ escaped for untrusted terms; documented the
compile-time identifier-source invariant.
Tests: new test_constant_time; likeEscape/likeContains/likePrefix cases added to
test_queryable. All 20 ctest targets pass. README + header docs updated.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
44 lines
1.6 KiB
C++
44 lines
1.6 KiB
C++
// Tests for oatpp-authkit/util/ConstantTime.hpp (authkit#16 L-7).
|
|
// Verifies functional correctness; timing-invariance is a property of the
|
|
// branch-free implementation, not asserted here.
|
|
|
|
#include "oatpp-authkit/util/ConstantTime.hpp"
|
|
|
|
#include <cstdio>
|
|
#include <string>
|
|
|
|
namespace {
|
|
|
|
int g_failures = 0;
|
|
#define REQUIRE(expr) do { \
|
|
if (!(expr)) { \
|
|
std::fprintf(stderr, "FAIL %s:%d %s\n", __FILE__, __LINE__, #expr); \
|
|
++g_failures; \
|
|
} \
|
|
} while (0)
|
|
|
|
using namespace oatpp_authkit;
|
|
|
|
void test_constant_time_equals() {
|
|
REQUIRE(constantTimeEquals("", ""));
|
|
REQUIRE(constantTimeEquals("abc", "abc"));
|
|
REQUIRE(constantTimeEquals(std::string(64, 'a'), std::string(64, 'a')));
|
|
|
|
REQUIRE(!constantTimeEquals("abc", "abd")); // differ at last byte
|
|
REQUIRE(!constantTimeEquals("abc", "xbc")); // differ at first byte
|
|
REQUIRE(!constantTimeEquals("abc", "ab")); // length mismatch (prefix)
|
|
REQUIRE(!constantTimeEquals("ab", "abc"));
|
|
REQUIRE(!constantTimeEquals("", "a"));
|
|
|
|
// Embedded NUL handled (string-length aware, not C-string).
|
|
REQUIRE(constantTimeEquals(std::string("a\0b", 3), std::string("a\0b", 3)));
|
|
REQUIRE(!constantTimeEquals(std::string("a\0b", 3), std::string("a\0c", 3)));
|
|
}
|
|
|
|
} // namespace
|
|
|
|
int main() {
|
|
test_constant_time_equals();
|
|
std::printf("%s (%d failures)\n", g_failures ? "FAIL" : "OK", g_failures);
|
|
return g_failures ? 1 : 0;
|
|
}
|